capistrant commented on code in PR #19843:
URL: https://github.com/apache/druid/pull/19843#discussion_r3705429825
##########
server/src/main/java/org/apache/druid/segment/loading/SegmentLocalCacheManager.java:
##########
@@ -465,13 +465,13 @@ private void deleteSegmentInfoFile(DataSegment segment)
}
/**
- * Write the info file for a partial-load segment, overwriting any existing
content atomically. Distinct from
- * {@link #storeInfoFile} which skips the write when the file already
exists, for partial segments we must
- * unconditionally rewrite so an incoming rule swap (new {@code
fingerprint}/{@code delegate} inside the
- * wrapped load spec) reaches disk. Otherwise bootstrap after a restart
would restore the segment using the
- * prior wrapper and re-announce the old rule until the coordinator resyncs.
+ * Write the info file for a segment, overwriting any existing content
atomically. Distinct from
+ * {@link #storeInfoFile}, which skips the write when the file already
exists: a partial-load transition must reach
+ * disk unconditionally, whether it is a rule swap (new {@code
fingerprint}/{@code delegate} inside the wrapped load
+ * spec) or a return to a regular full load (no wrapper at all). Otherwise
bootstrap after a restart would restore
+ * the segment using the prior wrapper and re-announce the old rule until
the coordinator resyncs.
*/
- private void writePartialInfoFile(DataSegment segment) throws IOException
+ private void rewriteInfoFile(DataSegment segment) throws IOException
Review Comment:
not totally sure this rename was necessary. But since it is now called
during a partial --> full migration I took out the partial bit. I'm ok to add
back if we want
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
