FrankChen021 commented on code in PR #19814:
URL: https://github.com/apache/druid/pull/19814#discussion_r3712426195
##########
website/package.json:
##########
@@ -39,5 +39,13 @@
"react": "^18.2.0",
"react-dom": "^18.2.0",
"replace-in-file": "^4.3.1"
+ },
+ "overrides": {
+ "brace-expansion": "5.0.8",
Review Comment:
[P2] Avoid forcing brace-expansion 5 into minimatch 3
The global override replaces [email protected]'s brace-expansion@^1.1.7 with
v5. Minimatch 3 imports this dependency as a callable function, while v5's
CommonJS entry exports an object containing expand. Consequently, brace
patterns such as a{b,c} throw TypeError: expand is not a function. This affects
the installed docusaurus-lunr-search, glob@7, and serve-handler consumers;
ordinary patterns can let current build checks pass. Upgrade those minimatch
consumers or retain a security-fixed release with the callable API instead of
applying this global major-version override.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
