gianm commented on a change in pull request #7267: Logic adjustments to
SeekableStreamIndexTaskRunner.
URL: https://github.com/apache/incubator-druid/pull/7267#discussion_r265842937
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskRunner.java
##########
@@ -375,7 +380,7 @@ private TaskStatus runInternal(TaskToolbox toolbox) throws
Exception
// Sanity checks.
if
(!restoredNextPartitions.getStream().equals(ioConfig.getStartPartitions().getStream()))
{
throw new ISE(
- "WTF?! Restored stream[%s] but expected stream[%s]",
+ "WTF?! Restored topic[%s] but expected topic[%s]",
Review comment:
OK, I'll revert these changes, but I do think it's better w/ Kafkaesque
terminology
(https://github.com/apache/incubator-druid/pull/7267#issuecomment-473134915).
Especially because "sequence" already means something else in the context of
seekable stream tasks (SequenceMetadata, sequenceName, etc) and so it is best
to avoid. But this can be driven separately and doesn't need to be looped into
this logic adjustment PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
