github-advanced-security[bot] commented on code in PR #19879:
URL: https://github.com/apache/druid/pull/19879#discussion_r3717686865
##########
extensions-core/histogram/src/test/java/org/apache/druid/query/aggregation/histogram/ApproximateHistogramGroupByQueryTest.java:
##########
@@ -110,26 +106,21 @@
return constructors;
}
- public ApproximateHistogramGroupByQueryTest(
- String testName,
- GroupByQueryRunnerFactory factory,
- QueryRunner runner
- )
- {
- this.factory = factory;
- this.runner = runner;
- ApproximateHistogramDruidModule.registerSerde();
- }
-
- @After
+ @AfterEach
public void teardown() throws IOException
{
RESOURCE_CLOSER.close();
}
- @Test
- public void testGroupByWithApproximateHistogramAgg()
+ @MethodSource("constructorFeeder")
+ @ParameterizedTest(name = "{0}")
+ public void testGroupByWithApproximateHistogramAgg(
+ String testName,
+ GroupByQueryRunnerFactory factory,
Review Comment:
## CodeQL / Useless parameter
The parameter 'factory' is never used.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11611)
##########
extensions-core/histogram/src/test/java/org/apache/druid/query/aggregation/histogram/ApproximateHistogramGroupByQueryTest.java:
##########
@@ -189,51 +180,59 @@
TestHelper.assertExpectedObjects(expectedResults, results, "approx-histo");
}
- @Test(expected = IllegalArgumentException.class)
- public void testGroupByWithSameNameComplexPostAgg()
+ @MethodSource("constructorFeeder")
+ @ParameterizedTest(name = "{0}")
+ public void testGroupByWithSameNameComplexPostAgg(
+ String testName,
+ GroupByQueryRunnerFactory factory,
Review Comment:
## CodeQL / Useless parameter
The parameter 'factory' is never used.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11609)
##########
extensions-core/histogram/src/test/java/org/apache/druid/query/aggregation/histogram/FixedBucketsHistogramGroupByQueryTest.java:
##########
@@ -110,28 +106,21 @@
return constructors;
}
- @SuppressWarnings("unused")
- public FixedBucketsHistogramGroupByQueryTest(
- String testName,
- GroupByQueryRunnerFactory factory,
- QueryRunner runner
- )
- {
- this.factory = factory;
- this.runner = runner;
-
- ApproximateHistogramDruidModule.registerSerde();
- }
-
- @After
+ @AfterEach
public void teardown() throws IOException
{
RESOURCE_CLOSER.close();
}
- @Test
- public void testGroupByWithFixedHistogramAgg()
+ @MethodSource("constructorFeeder")
+ @ParameterizedTest(name = "{0}")
+ public void testGroupByWithFixedHistogramAgg(
+ String testName,
Review Comment:
## CodeQL / Useless parameter
The parameter 'testName' is never used.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11614)
##########
extensions-core/histogram/src/test/java/org/apache/druid/query/aggregation/histogram/ApproximateHistogramGroupByQueryTest.java:
##########
@@ -110,26 +106,21 @@
return constructors;
}
- public ApproximateHistogramGroupByQueryTest(
- String testName,
- GroupByQueryRunnerFactory factory,
- QueryRunner runner
- )
- {
- this.factory = factory;
- this.runner = runner;
- ApproximateHistogramDruidModule.registerSerde();
- }
-
- @After
+ @AfterEach
public void teardown() throws IOException
{
RESOURCE_CLOSER.close();
}
- @Test
- public void testGroupByWithApproximateHistogramAgg()
+ @MethodSource("constructorFeeder")
+ @ParameterizedTest(name = "{0}")
+ public void testGroupByWithApproximateHistogramAgg(
+ String testName,
Review Comment:
## CodeQL / Useless parameter
The parameter 'testName' is never used.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11610)
##########
extensions-core/histogram/src/test/java/org/apache/druid/query/aggregation/histogram/FixedBucketsHistogramGroupByQueryTest.java:
##########
@@ -191,51 +180,59 @@
TestHelper.assertExpectedObjects(expectedResults, results, "fixed-histo");
}
- @Test(expected = IllegalArgumentException.class)
- public void testGroupByWithSameNameComplexPostAgg()
+ @MethodSource("constructorFeeder")
+ @ParameterizedTest(name = "{0}")
+ public void testGroupByWithSameNameComplexPostAgg(
+ String testName,
Review Comment:
## CodeQL / Useless parameter
The parameter 'testName' is never used.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11612)
##########
extensions-core/histogram/src/test/java/org/apache/druid/query/aggregation/histogram/ApproximateHistogramGroupByQueryTest.java:
##########
@@ -189,51 +180,59 @@
TestHelper.assertExpectedObjects(expectedResults, results, "approx-histo");
}
- @Test(expected = IllegalArgumentException.class)
- public void testGroupByWithSameNameComplexPostAgg()
+ @MethodSource("constructorFeeder")
+ @ParameterizedTest(name = "{0}")
+ public void testGroupByWithSameNameComplexPostAgg(
+ String testName,
Review Comment:
## CodeQL / Useless parameter
The parameter 'testName' is never used.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11608)
##########
extensions-core/histogram/src/test/java/org/apache/druid/query/aggregation/histogram/FixedBucketsHistogramGroupByQueryTest.java:
##########
@@ -191,51 +180,59 @@
TestHelper.assertExpectedObjects(expectedResults, results, "fixed-histo");
}
- @Test(expected = IllegalArgumentException.class)
- public void testGroupByWithSameNameComplexPostAgg()
+ @MethodSource("constructorFeeder")
+ @ParameterizedTest(name = "{0}")
+ public void testGroupByWithSameNameComplexPostAgg(
+ String testName,
+ GroupByQueryRunnerFactory factory,
Review Comment:
## CodeQL / Useless parameter
The parameter 'factory' is never used.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11613)
##########
extensions-core/histogram/src/test/java/org/apache/druid/query/aggregation/histogram/FixedBucketsHistogramGroupByQueryTest.java:
##########
@@ -110,28 +106,21 @@
return constructors;
}
- @SuppressWarnings("unused")
- public FixedBucketsHistogramGroupByQueryTest(
- String testName,
- GroupByQueryRunnerFactory factory,
- QueryRunner runner
- )
- {
- this.factory = factory;
- this.runner = runner;
-
- ApproximateHistogramDruidModule.registerSerde();
- }
-
- @After
+ @AfterEach
public void teardown() throws IOException
{
RESOURCE_CLOSER.close();
}
- @Test
- public void testGroupByWithFixedHistogramAgg()
+ @MethodSource("constructorFeeder")
+ @ParameterizedTest(name = "{0}")
+ public void testGroupByWithFixedHistogramAgg(
+ String testName,
+ GroupByQueryRunnerFactory factory,
Review Comment:
## CodeQL / Useless parameter
The parameter 'factory' is never used.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11615)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
