kfaraz commented on PR #19687: URL: https://github.com/apache/druid/pull/19687#issuecomment-5187483569
Thanks for the suggestions, @vogievetsky ! Couple of things that I would like to have in this PR before we merge this off: - Use a slider for optimal idle ratio (same as lagWeight/idleWeight) - Keep the fields which are provided by the user (such as `optimalIdleRatio`, `taskCountMin`, `taskCountMax`, etc) and the fields which are determined from the current state of the cluster (such as `processingRate`, `partitionCount`, `pollIdleRatio`, etc.) in separate columns - Fix the API path - More simulation data points for lag < criticalLag. There isn't much value in having data points >> criticalLag, since they will always resolve to `taskCountMax`. I will try to address these in the next couple of days. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
