FrankChen021 commented on code in PR #19877:
URL: https://github.com/apache/druid/pull/19877#discussion_r3718164913
##########
extensions-core/stats/src/test/java/org/apache/druid/query/aggregation/variance/VarianceTimeseriesQueryTest.java:
##########
@@ -73,9 +70,16 @@ public VarianceTimeseriesQueryTest(
.context(ImmutableMap.of("vectorize", vectorize
? "force" : "false"));
}
- @Test
- public void testTimeseriesWithNullFilterOnNonExistentDimension()
+ @MethodSource("constructorFeeder")
+ @ParameterizedTest(name = "{0}:descending={1}")
+ public void testTimeseriesWithNullFilterOnNonExistentDimension(
+ QueryRunner runner,
+ boolean descending,
+ boolean vectorize,
+ List<AggregatorFactory> aggregatorFactories
+ )
{
+ initVarianceTimeseriesQueryTest(runner, descending, vectorize,
aggregatorFactories);
Review Comment:
Fixed in commit `694e17cc4c`. The `aggregatorFactories` parameter was not
read by this initializer. It is now removed from the method signature, and
`constructorFeeder` returns only the three arguments consumed by the Jupiter
test method: runner, descending, and vectorize. Validation: 264 focused
variance tests passed; Checkstyle reported 0 violations and SpotBugs reported 0
bugs/errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
