FrankChen021 commented on code in PR #19822:
URL: https://github.com/apache/druid/pull/19822#discussion_r3720698629
##########
processing/src/test/java/org/apache/druid/segment/IndexMergerV9WithSpatialIndexTest.java:
##########
@@ -476,8 +470,8 @@ private static QueryableIndex makeMergedQueryableIndex(
}
- File tmpFile = File.createTempFile("yay", "who");
- tmpFile.delete();
+ final File tmpFile = FileUtils.createTempDir("spatial-index-merge");
+ tmpFile.deleteOnExit();
Review Comment:
Addressed in 7bb8b374cd. The class-level closer now retains the
parameterized test indexes until @AfterClass, closes merge inputs after
construction, and recursively deletes each registered temp root after the
mapped indexes close. Verified with `mvn -ntp test -pl processing -am
-Dtest=org.apache.druid.segment.IndexMergerV9WithSpatialIndexTest
-Dsurefire.failIfNoSpecifiedTests=false -Pskip-static-checks
-Dweb.console.skip=true -Djava.io.tmpdir=/private/tmp/druid-pr19822-maven-tmp
-T1C` (36 tests passed); no `spatial-index*` temp trees remained afterward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
