capistrant opened a new pull request, #19890:
URL: https://github.com/apache/druid/pull/19890
### Description
Fix a regression in that we were not honoring our s3 client defaults for
multipart uploads + not honoring any operator override. Without this change we
use multipart but use the sdk default which appears to be 8MB chunks instead of
our default of 20.
I have personally felt this impact during MSQ compaction with s3 throttling
during the segment pushing at the end of a task. In investigating, I noticed
that even if I tried to modify the configs, they were not being honored by the
client.
#### Release note
Fixes a regression that was preventing s3 multipart upload configs from
taking effect.
<hr>
##### Key changed/added classes in this PR
* `ServerSideEncryptingAmazonS3.java`
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
