github-advanced-security[bot] commented on code in PR #19893:
URL: https://github.com/apache/druid/pull/19893#discussion_r3724324364
##########
extensions-core/s3-extensions/src/test/java/org/apache/druid/storage/s3/output/RetryableS3OutputStreamTest.java:
##########
@@ -217,11 +219,71 @@
s3.assertCancelled();
}
+ /**
+ * A multipart upload costs three S3 requests at minimum — create, upload
part, complete — so a stream small enough
+ * to need only one part should not use one. A task writes one object per
output partition, and every request lands
+ * on the same key prefix, so the per-object floor sets the burst rate
against that prefix.
+ */
+ @Test
+ public void testStreamFittingInOneChunkIsUploadedWithASinglePut() throws
IOException
+ {
+ chunkSize = 10;
+ ByteBuffer bb = ByteBuffer.allocate(Integer.BYTES);
+ try (RetryableS3OutputStream out =
+ new RetryableS3OutputStream(config, s3, path, s3UploadManager)) {
+ bb.putInt(1);
+ out.write(bb.array());
+ }
+
+ Assertions.assertEquals(0, s3.createMultipartUploadCount);
+ Assertions.assertEquals(0, s3.partRequests.size());
+ Assertions.assertNull(s3.completeRequest);
+ Assertions.assertEquals(ImmutableList.of((long) Integer.BYTES),
s3.putObjectContentLengths);
+ }
+
+ /**
+ * Once a stream outgrows a single chunk it must use multipart, costing one
create, one request per part, and one
+ * complete.
+ */
+ @Test
+ public void testStreamSpanningMultipleChunksUsesMultipartUpload() throws
IOException
+ {
+ chunkSize = 10;
+ ByteBuffer bb = ByteBuffer.allocate(Integer.BYTES);
+ try (RetryableS3OutputStream out =
+ new RetryableS3OutputStream(config, s3, path, s3UploadManager)) {
+ for (int i = 0; i < 25; i++) {
+ bb.clear();
+ bb.putInt(i);
+ out.write(bb.array());
+ }
+ }
+
+ Assertions.assertEquals(1, s3.createMultipartUploadCount);
+ Assertions.assertEquals(10, s3.partRequests.size());
+ Assertions.assertEquals(0, s3.putObjectContentLengths.size());
+ s3.assertCompleted(chunkSize, Integer.BYTES * 25);
Review Comment:
## CodeQL / Result of multiplication cast to wider type
Potential overflow in [int multiplication](1) before it is converted to long
by use in an invocation context.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11634)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
