shuqi7 commented on a change in pull request #7242: [Console] Add compaction
dialog in druid console which allows users to add/edit data source compaction
configuration
URL: https://github.com/apache/incubator-druid/pull/7242#discussion_r265868111
##########
File path: web-console/src/components/filler.tsx
##########
@@ -257,3 +259,63 @@ export class TagInput extends
React.Component<TagInputProps, { stringValue: stri
/>;
}
}
+
+interface JSONInputProps extends React.Props<any>{
+ onChange: (newValue: string) => void;
+ value: JSON;
+ updateErrors: ((newValue: string) => void)
Review comment:
The dialog needs to know which JSON input has invalid value so the submit
button could be disabled. It's taking a string since it's the raw value in the
input; this raw value will be checked if it could be parsed into JSON. The
dialog will then check if all fields have valid JSONs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
