capistrant commented on code in PR #19892:
URL: https://github.com/apache/druid/pull/19892#discussion_r3731974792
##########
extensions-core/s3-extensions/src/main/java/org/apache/druid/storage/s3/ServerSideEncryptingAmazonS3.java:
##########
@@ -453,6 +462,11 @@ public static AwsCredentialsProvider
createAssumeRoleCredentialsProvider(
if (awsEndpointConfig != null && awsEndpointConfig.getSigningRegion() !=
null) {
stsBuilder.region(Region.of(awsEndpointConfig.getSigningRegion()));
}
+ if (awsClientConfig != null) {
Review Comment:
regarding S3InputSource... I actually don't want to be adding that to scope
in this PR. the docs explicitly talking so confidently about this config for
tasks was a mistake and has been reverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
