FrankChen021 commented on code in PR #19922:
URL: https://github.com/apache/druid/pull/19922#discussion_r3739909004
##########
indexing-service/src/test/java/org/apache/druid/indexing/overlord/http/OverlordTest.java:
##########
@@ -264,16 +265,17 @@ public MockTaskRunner get()
EmittingLogger.registerEmitter(serviceEmitter);
}
- @Test(timeout = 60_000L)
+ @Timeout(60)
+ @Test
public void testOverlordRun() throws Exception
{
// basic task master lifecycle test
overlord.start();
while (!overlord.isLeader()) {
Thread.sleep(10);
}
- Assert.assertEquals(overlord.getCurrentLeader(),
druidNode.getHostAndPort());
- Assert.assertEquals(Optional.absent(), overlord.getRedirectLocation());
+ Assertions.assertEquals(overlord.getCurrentLeader(),
druidNode.getHostAndPort());
Review Comment:
Addressed in the existing worktree: the assertion now uses the conventional
expected/actual order, `Assertions.assertEquals(druidNode.getHostAndPort(),
overlord.getCurrentLeader())`. This thread is outdated against the current
diff, and the focused Overlord test passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
