FrankChen021 commented on code in PR #19923:
URL: https://github.com/apache/druid/pull/19923#discussion_r3739910838
##########
indexing-service/src/test/java/org/apache/druid/indexing/seekablestream/RecordSupplierInputSourceTest.java:
##########
@@ -69,8 +69,7 @@ public class RecordSupplierInputSourceTest extends
InitializedNullHandlingTest
private static final int NUM_ROWS = 128;
private static final String TIMESTAMP_STRING = "2019-01-01";
- @Rule
- public TemporaryFolder temporaryFolder = new TemporaryFolder();
+ private final File temporaryFolder = FileUtils.createTempDir();
@Test
Review Comment:
Addressed in the existing local edit: the temp directory created by
FileUtils.createTempDir is deleted in @AfterEach, restoring the old
TemporaryFolder cleanup behavior.
##########
indexing-service/src/test/java/org/apache/druid/indexing/seekablestream/supervisor/autoscaler/CostBasedAutoScalerConfigTest.java:
##########
@@ -358,9 +391,9 @@
"{\"autoScalerStrategy\":\"costBased\",\"enableTaskAutoScaler\":true,\"taskCountMax\":10,\"taskCountMin\":1}",
CostBasedAutoScalerConfig.class
);
- Assert.assertEquals(defaultMinTriggerMillis,
config.getMinTriggerScaleActionFrequencyMillis());
- Assert.assertEquals(defaultUp, config.getMinScaleUpDelay());
- Assert.assertEquals(defaultDown, config.getMinScaleDownDelay());
+ Assertions.assertEquals(defaultMinTriggerMillis,
config.getMinTriggerScaleActionFrequencyMillis());
Review Comment:
Evaluated and intentionally retained. This is an explicit serde
compatibility test covering the deprecated accessor across legacy and
forward-compatible configurations. Replacing these calls with directional
accessors would lose coverage of the compatibility API, so no code change is
needed.
##########
indexing-service/src/test/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisorSpecTest.java:
##########
@@ -381,20 +385,20 @@
"id1"
);
SupervisorTaskAutoScaler autoscaler = spec.createAutoscaler(supervisor4);
- Assert.assertTrue(autoscaler instanceof LagBasedAutoScaler);
+ Assertions.assertTrue(autoscaler instanceof LagBasedAutoScaler);
LagBasedAutoScaler lagBasedAutoScaler = (LagBasedAutoScaler) autoscaler;
LagBasedAutoScalerConfig lagBasedAutoScalerConfig =
lagBasedAutoScaler.getAutoScalerConfig();
-
Assert.assertEquals(lagBasedAutoScalerConfig.getLagCollectionIntervalMillis(),
1);
-
Assert.assertEquals(lagBasedAutoScalerConfig.getLagCollectionRangeMillis(),
600000);
-
Assert.assertEquals(lagBasedAutoScalerConfig.getScaleActionStartDelayMillis(),
300000);
- Assert.assertEquals(lagBasedAutoScalerConfig.getScaleActionPeriodMillis(),
60000);
- Assert.assertEquals(lagBasedAutoScalerConfig.getScaleOutThreshold(),
6000000);
- Assert.assertEquals(lagBasedAutoScalerConfig.getScaleInThreshold(),
1000000);
- Assert.assertEquals(lagBasedAutoScalerConfig.getTaskCountMax(), 4);
- Assert.assertEquals(lagBasedAutoScalerConfig.getTaskCountMin(), 1);
- Assert.assertEquals(lagBasedAutoScalerConfig.getScaleInStep(), 1);
- Assert.assertEquals(lagBasedAutoScalerConfig.getScaleOutStep(), 2);
-
Assert.assertEquals(lagBasedAutoScalerConfig.getMinTriggerScaleActionFrequencyMillis(),
600000);
+
Assertions.assertEquals(lagBasedAutoScalerConfig.getLagCollectionIntervalMillis(),
1);
+
Assertions.assertEquals(lagBasedAutoScalerConfig.getLagCollectionRangeMillis(),
600000);
+
Assertions.assertEquals(lagBasedAutoScalerConfig.getScaleActionStartDelayMillis(),
300000);
+
Assertions.assertEquals(lagBasedAutoScalerConfig.getScaleActionPeriodMillis(),
60000);
+ Assertions.assertEquals(lagBasedAutoScalerConfig.getScaleOutThreshold(),
6000000);
+ Assertions.assertEquals(lagBasedAutoScalerConfig.getScaleInThreshold(),
1000000);
+ Assertions.assertEquals(lagBasedAutoScalerConfig.getTaskCountMax(), 4);
+ Assertions.assertEquals(lagBasedAutoScalerConfig.getTaskCountMin(), 1);
+ Assertions.assertEquals(lagBasedAutoScalerConfig.getScaleInStep(), 1);
+ Assertions.assertEquals(lagBasedAutoScalerConfig.getScaleOutStep(), 2);
+
Assertions.assertEquals(lagBasedAutoScalerConfig.getMinTriggerScaleActionFrequencyMillis(),
600000);
Review Comment:
Evaluated and intentionally retained. This assertion covers the retained
deprecated lag-frequency accessor and its default behavior on the supervisor
config. Replacing it with a directional delay accessor would no longer exercise
the compatibility API, so there is no safe replacement that preserves the
coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
