This is an automated email from the ASF dual-hosted git repository.
FrankChen021 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git
The following commit(s) were added to refs/heads/master by this push:
new 48a9eeab999 fix issue that fails datasketches tests if they run in
certain order(s) (#19924)
48a9eeab999 is described below
commit 48a9eeab99944bff722d9452ba95d41bcb2bcac9
Author: Lucas Capistrant <[email protected]>
AuthorDate: Sat Aug 8 11:52:56 2026 -0500
fix issue that fails datasketches tests if they run in certain order(s)
(#19924)
---
.../druid/segment/DatasketchesProjectionTest.java | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git
a/extensions-core/datasketches/src/test/java/org/apache/druid/segment/DatasketchesProjectionTest.java
b/extensions-core/datasketches/src/test/java/org/apache/druid/segment/DatasketchesProjectionTest.java
index 95196acaded..f261199ad2e 100644
---
a/extensions-core/datasketches/src/test/java/org/apache/druid/segment/DatasketchesProjectionTest.java
+++
b/extensions-core/datasketches/src/test/java/org/apache/druid/segment/DatasketchesProjectionTest.java
@@ -19,6 +19,7 @@
package org.apache.druid.segment;
+import com.fasterxml.jackson.databind.ObjectMapper;
import com.google.common.collect.ImmutableMap;
import org.apache.datasketches.common.Family;
import org.apache.datasketches.hll.HllSketch;
@@ -97,6 +98,10 @@ public class DatasketchesProjectionTest extends
InitializedNullHandlingTest
private static final Closer CLOSER = Closer.create();
private static final Logger LOG = new
Logger(DatasketchesProjectionTest.class);
+ // Not TestHelper.JSON_MAPPER: Jackson caches the AggregatorFactory subtype
resolver when it first builds a
+ // deserializer, so the sketch modules must be registered before anything
else uses this mapper.
+ private static final ObjectMapper JSON_MAPPER = TestHelper.makeJsonMapper();
+
private static final List<AggregateProjectionSpec> PROJECTIONS =
Collections.singletonList(
AggregateProjectionSpec.builder("a_projection")
.virtualColumns(
@@ -139,15 +144,15 @@ public class DatasketchesProjectionTest extends
InitializedNullHandlingTest
public static Collection<?> constructorFeeder()
{
HllSketchModule.registerSerde();
- TestHelper.JSON_MAPPER.registerModules(new
HllSketchModule().getJacksonModules());
+ JSON_MAPPER.registerModules(new HllSketchModule().getJacksonModules());
SketchModule.registerSerde();
- TestHelper.JSON_MAPPER.registerModules(new
SketchModule().getJacksonModules());
+ JSON_MAPPER.registerModules(new SketchModule().getJacksonModules());
KllSketchModule.registerSerde();
- TestHelper.JSON_MAPPER.registerModules(new
KllSketchModule().getJacksonModules());
+ JSON_MAPPER.registerModules(new KllSketchModule().getJacksonModules());
DoublesSketchModule.registerSerde();
- TestHelper.JSON_MAPPER.registerModules(new
DoublesSketchModule().getJacksonModules());
+ JSON_MAPPER.registerModules(new DoublesSketchModule().getJacksonModules());
ArrayOfDoublesSketchModule.registerSerde();
- TestHelper.JSON_MAPPER.registerModules(new
ArrayOfDoublesSketchModule().getJacksonModules());
+ JSON_MAPPER.registerModules(new
ArrayOfDoublesSketchModule().getJacksonModules());
final List<Object[]> constructors = new ArrayList<>();
final DimensionsSpec.Builder dimensionsBuilder =
@@ -221,7 +226,7 @@ public class DatasketchesProjectionTest extends
InitializedNullHandlingTest
{
File tmp = FileUtils.createTempDir();
CLOSER.register(tmp::delete);
- return IndexBuilder.create()
+ return IndexBuilder.create(JSON_MAPPER)
.tmpDir(tmp)
.schema(
IncrementalIndexSchema.builder()
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
