shuqi7 commented on issue #7268: Fixed height issue of dynamic config dialog 
where the user cannot scroll
URL: https://github.com/apache/incubator-druid/pull/7268#issuecomment-473434626
 
 
   > > Searching codebase for 'bp3', I also see a
   > > ```
   > > .retention-dialog {
   > >   width: 750px;
   > > 
   > >   .dialog-body {
   > >     overflow: scroll;
   > >     max-height: 70vh;
   > > 
   > >     .bp3-form-group {
   > >       margin: 0 0 5px;
   > >     }
   > > ...
   > > ```
   > > in `web-console/src/dialogs/retention-dialog.scss`
   > > Unsure if it matters for anything 🙃
   > 
   > Will test and fix that
   
   The last `bp3` class is removed in the PR #7276 when fixing bugs in 
retention cell and retention dialog

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to