gianm commented on a change in pull request #7212: Support Kafka supervisor
adopting running tasks between versions
URL: https://github.com/apache/incubator-druid/pull/7212#discussion_r266146825
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java
##########
@@ -1640,19 +1648,31 @@ private boolean isTaskCurrent(int taskGroupId, String
taskId)
SeekableStreamIndexTask<PartitionIdType, SequenceOffsetType> task =
(SeekableStreamIndexTask<PartitionIdType, SequenceOffsetType>) taskOptional
.get();
- String taskSequenceName = task.getIOConfig().getBaseSequenceName();
Review comment:
Every task in a task group needs to have the same sequence name (so replicas
segment allocations match up), meaning you _do_ need to remember
`task.getIOConfig().getBaseSequenceName()`, and should probably assign it as
the sequence name for the relevant task group before starting to create new
tasks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
