abhishekrb19 opened a new pull request, #19953:
URL: https://github.com/apache/druid/pull/19953
Summary:
The shared test `MetadataManager` in `DruidCoordinatorTest` intentionally
passes
null supervisor/audit/indexer managers. With metadata-store cleanup
enabled (the
`CoordinatorKillConfigs.DEFAULT`), the `Kill*` duties dereference those
nulls and
emit unrelated NPE alerts on every run that starts a real coordinator.
Disable metadata cleanup in the shared coordinator config so the `Kill*`
duties
self-skip instead of dereferencing the null managers. These duties are
tested in other
places anyway and not asserted in this test.
Alternative considered: keep `DEFAULT` and supply mocked managers
(auditManager,
metadataSupervisorManager, storageCoordinator, connector, etc) with
stubbed returns.
Rejected — it needs several mocks + stubs for duties these tests never
assert on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
