kfaraz commented on code in PR #19921:
URL: https://github.com/apache/druid/pull/19921#discussion_r3755214172
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskLockbox.java:
##########
@@ -571,6 +572,13 @@ private TaskLockPosse createOrFindLockPosse(LockRequest
request, Task task, bool
throw new ISE("Unable to grant LockPosse to inactive Task [%s]",
task.getId());
}
+ if (request.getType() == TaskLockType.KILL &&
!KillUnusedSegmentsTask.TYPE.equals(task.getType())) {
Review Comment:
Yeah, this is on purpose but I see the problem. If we wanted to use the
`KILL` lock type for manual kill tasks, we would also need to do the validation
on mark-as-used even if embedded kill was disabled.
I don't see a clear way to do that, except maybe always honoring the
`bufferPeriod`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
