kfaraz commented on PR #19984: URL: https://github.com/apache/druid/pull/19984#issuecomment-5266886509
Thanks for the review, @gargvishesh ! > You would tackle the fail-everything-on-misconfigured-task in a separate PR? I looked into this, but the case here doesn't seem like one where we are iterating over each task separately. https://github.com/apache/druid/blob/5dd74a82c386dbcf7fcb16ea41d6e190e66d8fee/indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskQueue.java#L423-L427 This seems like a one off thing. I suppose we could try to invoke `getPriority` on each task within a for loop that has a try-catch but it seems overkill. We might want to have a try-catch for the `updateTaskEntry` invocations though. I will create a separate PR for that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
