shuqi7 commented on a change in pull request #7242: Add compaction dialog in
druid console which allows users to add/edit data source compaction
configuration
URL: https://github.com/apache/incubator-druid/pull/7242#discussion_r266170596
##########
File path: web-console/src/components/filler.tsx
##########
@@ -257,3 +259,63 @@ export class TagInput extends
React.Component<TagInputProps, { stringValue: stri
/>;
}
}
+
+interface JSONInputProps extends React.Props<any>{
+ onChange: (newValue: string) => void;
+ value: JSON;
+ updateErrors: ((newValue: string) => void)
Review comment:
I am refactoring the entire JSON validating process.
Originally, the dialog has an object where the property is the JSON input
name. and value is a boolean to tell if the input is valid. The dialog gotta
check if every property is true.
I'm changing this errors tracking/checking process into auto-form, and auto
form will update dialog by telling a boolean value indicating if all JSON
inputs are valid or not. Now, auto-form will have a state which is object
{string: boolean}, tracking if every JSON input is valid. JSON input will do
the checking and change the object in auto-form by setting boolean values. I
think in this way it makes the auto form API easy to use when auto-form handles
the tracking and JSON input handles validating.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
