gianm commented on code in PR #20002:
URL: https://github.com/apache/druid/pull/20002#discussion_r3779140218
##########
extensions-core/s3-extensions/src/main/java/org/apache/druid/storage/s3/output/RetryableS3OutputStream.java:
##########
@@ -350,6 +360,18 @@ private void completeMultipartUpload()
catch (Exception e) {
throw new RuntimeException(e);
}
+
+ // If an error occurred during the upload of any part, we aborted the
whole upload and there is nothing to read
+ // downstream. We must throw here to indicate that the object was not
written and avoid callers assuming that the
+ // object is available for reading.
+ if (error) {
+ throw new IOE(
Review Comment:
Prefer making it a DruidException, category `RUNTIME_FAILURE`, persona
`OPERATOR`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
