gianm commented on code in PR #19985:
URL: https://github.com/apache/druid/pull/19985#discussion_r3786887710
##########
server/src/main/java/org/apache/druid/segment/loading/SegmentLocalCacheManager.java:
##########
@@ -566,8 +577,13 @@ public AcquireSegmentAction acquireSegment(final
DataSegment dataSegment, final
throw DruidException.forPersona(DruidException.Persona.USER)
.ofCategory(DruidException.Category.CAPACITY_EXCEEDED)
.build(
- "Unable to load segment[%s] on demand, ensure
enough disk space has been allocated to load all segments involved in the
query",
- dataSegment.getId()
+ "Unable to load segment[%s] on demand, ensure
enough disk space has been allocated "
Review Comment:
This is not an appropriate USER persona message, the USER should not see a
list of storage locations. Actually even the prior message wasn't great for a
USER: they can't "ensure enough disk space has been allocated". IMO, we can
keep the more detailed message, but retarget it to OPERATOR.
##########
server/src/main/java/org/apache/druid/segment/loading/StorageLocation.java:
##########
@@ -154,6 +154,7 @@ public StorageLocation(File path, long maxSizeBytes,
@Nullable Double freeSpaceP
} else {
this.freeSpaceToKeep = 0;
}
+ log.info("SegmentLocation[%s] configured with capacity[%,d] bytes.", path,
maxSizeBytes);
Review Comment:
`StorageLocation` (spelling). Please fix the other one (pre-existing prior
to this PR) too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
