vogievetsky commented on issue #7280: Added tslint to web console
URL: https://github.com/apache/incubator-druid/pull/7280#issuecomment-473620505
 
 
   I started this PR by committing the same tslint-file that was not the 
strictest and a bit out of date (new tslint rules were added since that file 
was written).
   I had a think about it and decided to go over all the rules and make the 
linter much more strict.
   In particular the new linter will ensure a consistent sort order and groping 
of imports, will also lint the React JSX part, and will make sure there is an 
Apache license header file.
   I have employed the autofixer (which has been a godsend) to make the 
majority of the changes in the actual diff. Having gone over all the 
[rules](https://palantir.github.io/tslint/rules/) I believe this is now 
sufficiently strict and good to go.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to