kfaraz commented on PR #20027: URL: https://github.com/apache/druid/pull/20027#issuecomment-5323676076
> The test case i added in this PR would fail without the change made. The case here is that we could have a skip interval in the middle of the day (10am - 12pm), and there're segments overlapping (0am - 10am) which get passed into findAndEnqueueSegmentsToCompact, so only the exact skip interval is not compacted but some segments during the day is still being compacted. Thanks for adding the test! The problem is that the `segment.getInterval()` still returns the original segment interval (which makes sense) rather than the interval aligned to the segment granularity. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
