zhang-arvin opened a new pull request, #20070:
URL: https://github.com/apache/druid/pull/20070

   ## Purpose
   
   Fix Jackson serialization failure for Long/Double/Float First/Last 
aggregator factories.
   
   Anonymous inner classes used as `NIL_AGGREGATOR` and `NIL_BUFFER_AGGREGATOR` 
were being serialized
   as `LongLastAggregatorFactory$1` instead of the registered `@JsonTypeName`. 
This caused the error:
   
   ```
   Could not resolve type id 'LongLastAggregatorFactory$1' into a subtype of 
AggregatorFactory
   ```
   
   ## Changes
   
   Converted all anonymous subclasses of `Aggregator` and `BufferAggregator` in 
the following 6 factory
   classes to private static named inner classes:
   
   - `LongLastAggregatorFactory`
   - `DoubleLastAggregatorFactory`
   - `FloatLastAggregatorFactory`
   - `LongFirstAggregatorFactory`
   - `DoubleFirstAggregatorFactory`
   - `FloatFirstAggregatorFactory`
   
   Each factory previously had two anonymous classes (`NIL_AGGREGATOR` and 
`NIL_BUFFER_AGGREGATOR`)
   that overrode `aggregate()` to be no-ops. These are now named inner classes 
(e.g.,
   `NilLongLastAggregator`, `NilLongLastBufferAggregator`) that correctly 
extend their parent classes
   with explicit constructors.
   
   Closes #7599


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to