FrankChen021 commented on code in PR #20056:
URL: https://github.com/apache/druid/pull/20056#discussion_r3813160754
##########
embedded-tests/src/test/java/org/apache/druid/testing/embedded/docker/IngestionDockerTest.java:
##########
@@ -54,14 +54,14 @@ protected EmbeddedDruidCluster
addServers(EmbeddedDruidCluster cluster)
return cluster
.useDefaultTimeoutForLatchableEmitter(240)
.useContainerFriendlyHostname()
+ .addServer(eventCollector)
Review Comment:
Thanks. K3sClusterResource.createConfigMapForCommonProperties has a separate
removal using the same misspelled modulesForEmbeddedTests key. Fixing only
DruidContainerResource.FORBIDDEN_PROPERTIES covers Docker paths but still leaks
druid.extensions.modulesForEmbeddedTest into Kubernetes pods. Please correct
both.
<!-- mergelens:review -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
