FrankChen021 commented on code in PR #20071:
URL: https://github.com/apache/druid/pull/20071#discussion_r3813153797
##########
processing/src/test/java/org/apache/druid/segment/join/PostJoinCursorTest.java:
##########
@@ -237,7 +237,7 @@ private void testAdvance(boolean withInterruption) throws
IOException, Interrupt
joinCursorThread.setUncaughtExceptionHandler(exceptionHandler);
joinCursorThread.start();
- countDownLatch.await(1, TimeUnit.SECONDS);
+ assertTrue(countDownLatch.await(1, TimeUnit.SECONDS));
Review Comment:
[P1] Timeout assertion can skip interrupt cleanup
If await returns false, the assertion throws before
joinCursorThread.interrupt(). The intentionally infinite, non-daemon test
thread can then continue indefinitely and hang the test JVM. Move interruption
and joining into cleanup that runs before or alongside the assertion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
