FrankChen021 commented on code in PR #20059:
URL: https://github.com/apache/druid/pull/20059#discussion_r3813298167
##########
server/src/test/java/org/apache/druid/server/coordinator/duty/RunRulesTest.java:
##########
@@ -1024,7 +1026,8 @@ public void testRulesRunOnNonOvershadowedSegmentsOnly()
* Replicants - 3
* Random balancer strategy should not assign anything and not get into loop
as there are not enough nodes for replication
*/
- @Test(timeout = 5000L)
+ @Test
+ @Timeout(value = 5000L, unit = TimeUnit.MILLISECONDS)
Review Comment:
Fixed in f1cd46b968. All three RunRulesTest timeout migrations now set
threadMode = ThreadMode.SEPARATE_THREAD, preserving JUnit 4 preemptive timeout
behavior. Verified with server test-compile, all 21 RunRulesTest tests,
Checkstyle, SpotBugs, and git diff --check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
