leventov commented on issue #7285: Fix concurrency of VersionedIntervalTimeline URL: https://github.com/apache/incubator-druid/issues/7285#issuecomment-474100570 I think we shouldn't add an annotation without enforcing that the annotated methods are not called from production code (that might be non-trivial). This is because in the absence of annotation when people should add "InTest" suffix to the method name, it's less likely that somebody makes a mistake and calls a method with "InTest" suffix in production code because it is too visible. Having an annotation, developers won't add "InTest" suffix to method names, and it will still be easy to mistakenly call them from production code.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
