FrankChen021 commented on PR #20108: URL: https://github.com/apache/druid/pull/20108#issuecomment-5375782699
> FYI @FrankChen021: this issue means we should avoid `@ParameterizedClass` in JUnit 5 for highly-parameterized classes. Yes, I noticed this problem and fixed one in #19859. But during the following migration, I deliberately kept using ParameteriedClass so that the diff is small and easy to review because every batch we migrated lots of test cases. I intended to handle this problem in a follow up PR to improve test performance, and now you patched several tests. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
