leventov commented on a change in pull request #7273: Fix some IntelliJ
inspections
URL: https://github.com/apache/incubator-druid/pull/7273#discussion_r266643824
##########
File path:
extensions-contrib/orc-extensions/src/main/java/org/apache/druid/data/input/orc/OrcHadoopInputRowParser.java
##########
@@ -246,15 +246,14 @@ static String typeStringFromParseSpec(ParseSpec
parseSpec)
builder.append(parseSpec.getTimestampSpec().getTimestampColumn()).append(":string");
// the typeString seems positionally dependent, so repeated timestamp
column causes incorrect mapping
if (parseSpec.getDimensionsSpec().getDimensionNames().size() > 0) {
- builder.append(",");
- builder.append(String.join(
Review comment:
@drcrallen the very line to which you left your first comment *is* required
for IntelliJ inspections. Removing `builder.append(",")` and
`builder.append(":string")` before and after this line and instead providing
additional arguments to `Collectors.joining()` is not required.
Do you want me to rollback the second part?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
