clintropolis commented on issue #7258: #5884 Avro Maps can't be flattened in 
Kafka Indexing on master
URL: https://github.com/apache/incubator-druid/pull/7258#issuecomment-474106178
 
 
   >I spend my morning trying to run a test case, but it's not so easy has 
using the io.confluent.kafka.serializers.KafkaAvroSerializer without a 
kafkaproducer is quite an hard job. I test it many times on real Confluent 5.1 
Kafka Cluster with Schema Registry.
   
   I think this issue would exist for any type of Avro indexing; like if you 
could create an Avro formatted file with a column that is a map type with utf8 
keys, you could test with the Hadoop indexing tests if that would be easier.
   
   That said, this change seems small and harmless enough that I think it would 
probably be ok without tests, so I will go ahead and approve.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to