FrankChen021 commented on code in PR #19627:
URL: https://github.com/apache/druid/pull/19627#discussion_r3838483019
##########
server/src/main/java/org/apache/druid/server/metrics/GroupByStatsMonitor.java:
##########
@@ -68,6 +68,7 @@ public boolean doMonitor(ServiceEmitter emitter)
emitter.emit(builder.setMetric("mergeBuffer/maxAcquisitionTimeNs",
statsContainer.getMaxMergeBufferAcquisitionTimeNs()));
emitter.emit(builder.setMetric("mergeBuffer/bytesUsed",
statsContainer.getTotalMergeBufferUsedBytes()));
emitter.emit(builder.setMetric("mergeBuffer/maxBytesUsed",
statsContainer.getMaxMergeBufferUsedBytes()));
+ emitter.emit(builder.setMetric("mergeBuffer/maxSpillProximity",
statsContainer.getMaxSpillProximity()));
Review Comment:
[P1] Add the new metric to the default Prometheus mapping
The PR emits the new `mergeBuffer/maxSpillProximity` metric, but the default
Prometheus mapping does not register it. With the default `dimensionMapPath`,
Prometheus only exports metrics listed in
`extensions-contrib/prometheus-emitter/src/main/resources/defaultMetrics.json`,
so this event is silently dropped for the default configuration. Add
`mergeBuffer/maxSpillProximity` as a no-dimension gauge to the default mapping
and cover the mapping in a test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
