davidalexander3986 commented on code in PR #20173:
URL: https://github.com/apache/druid/pull/20173#discussion_r3889501971
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/PartialSegmentMergeTask.java:
##########
@@ -295,13 +296,17 @@ private DataSegmentsWithSchemas mergeAndPushSegments(
), "version for interval[%s]", interval),
0
);
+ try (QueryableIndex index =
toolbox.getIndexIO().loadIndex(mergedFileAndDimensionNames.lhs)) {
Review Comment:
That's a fair point, butI'd rather not add an IndexIO.getNumRows(File)
helper with v9/v10 branching in this PR. BatchAppenderator already does the
same loadIndex + getNumRows() after merge, so this matches an existing ingest
path. The extra open is try-with-resources and short-lived; the merged file is
already on disk (and likely still in page cache).
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/PartialSegmentMergeTask.java:
##########
@@ -295,13 +296,17 @@ private DataSegmentsWithSchemas mergeAndPushSegments(
), "version for interval[%s]", interval),
0
);
+ try (QueryableIndex index =
toolbox.getIndexIO().loadIndex(mergedFileAndDimensionNames.lhs)) {
Review Comment:
That's a fair point, but I'd rather not add an IndexIO.getNumRows(File)
helper with v9/v10 branching in this PR. BatchAppenderator already does the
same loadIndex + getNumRows() after merge, so this matches an existing ingest
path. The extra open is try-with-resources and short-lived; the merged file is
already on disk (and likely still in page cache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
