FrankChen021 commented on code in PR #17355:
URL: https://github.com/apache/druid/pull/17355#discussion_r3934414904
##########
extensions-core/kafka-extraction-namespace/pom.xml:
##########
@@ -67,6 +67,18 @@
</exclusion>
</exclusions>
</dependency>
+ <dependency>
+ <groupId>software.amazon.msk</groupId>
+ <artifactId>aws-msk-iam-auth</artifactId>
+ <version>1.1.5</version>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
Review Comment:
[P1] Do not exclude the IAM plugin's runtime SDKs
This is the regular `aws-msk-iam-auth` artifact, and excluding every
transitive dependency leaves its required AWS SDK v2 classes out of the
extension. In v1.1.5, the normal `IAMLoginModule required;` path constructs
`MSKCredentialProvider`, which eagerly constructs
`EnhancedProfileCredentialsProvider` and therefore needs
`software.amazon.awssdk.auth.credentials.ProfileCredentialsProvider`; Druid
provides the AWS SDK v1 artifacts but has no AWS SDK v2 dependency. The first
IAM-authenticated Kafka consumer will consequently fail with
`NoClassDefFoundError` before loading credentials. Please retain the required
runtime dependencies (or use a bundled artifact) and apply the same fix to
`kafka-indexing-service/pom.xml`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
