FrankChen021 commented on code in PR #18525:
URL: https://github.com/apache/druid/pull/18525#discussion_r3986236730
##########
extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/KafkaIndexTaskIOConfig.java:
##########
@@ -66,7 +68,8 @@ public KafkaIndexTaskIOConfig(
@JsonProperty("configOverrides") @Nullable KafkaConfigOverrides
configOverrides,
@JsonProperty("multiTopic") @Nullable Boolean multiTopic,
@JsonProperty("refreshRejectionPeriodsInMinutes") Long
refreshRejectionPeriodsInMinutes,
- @JsonProperty("boundedStreamConfig") @Nullable BoundedStreamConfig
boundedStreamConfig
+ @JsonProperty("boundedStreamConfig") @Nullable BoundedStreamConfig
boundedStreamConfig,
+ @JsonProperty("headerBasedFilterConfig") @Nullable
KafkaHeaderBasedFilterConfig headerBasedFilterConfig
Review Comment:
[P1] Preserve the previous full constructor signature
Adding `headerBasedFilterConfig` changes the public 17-argument
constructor's JVM descriptor. The overload added below only preserves the
separate 12-argument convenience constructor, so extensions or other callers
compiled against the previous full signature fail with `NoSuchMethodError` even
when filtering is unused. Retain an overload with the old argument list that
delegates with a null filter.
##########
processing/src/main/java/org/apache/druid/segment/incremental/RowIngestionMetersTotals.java:
##########
@@ -44,32 +45,66 @@ public RowIngestionMetersTotals(
@JsonProperty("processedWithError") long processedWithError,
@JsonProperty("thrownAway") long thrownAway,
@JsonProperty("thrownAwayByReason") @Nullable Map<String, Long>
thrownAwayByReason,
- @JsonProperty("unparseable") long unparseable
+ @JsonProperty("unparseable") long unparseable,
+ @JsonProperty("filtered") long filtered
Review Comment:
[P1] Retain the old totals constructor overload
Adding `filtered` changes the public JSON-creator constructor from `(long,
long, long, long, Map<String, Long>, long)` to a seven-argument signature, but
no six-argument overload with both `thrownAway` and `thrownAwayByReason`
remains. Already-compiled callers using the previous constructor will fail with
`NoSuchMethodError` (and source callers will no longer compile); keep that
overload and default `filtered` to zero.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
