FrankChen021 commented on code in PR #19815:
URL: https://github.com/apache/druid/pull/19815#discussion_r3990224715
##########
web-console/package.json:
##########
@@ -155,12 +156,27 @@
"ts-loader": "^9.5.1",
"ts-node": "^10.9.2",
"typescript": "~5.5.4",
- "webpack": "^5.89.0",
+ "webpack": "^5.104.1",
"webpack-bundle-analyzer": "^4.10.1",
"webpack-cli": "^5.1.4",
"webpack-dev-server": "^5.2.6"
},
"overrides": {
- "@types/react": "$@types/react"
+ "@babel/core": "7.29.6",
+ "@tootallnate/once": "2.0.1",
+ "@types/react": "$@types/react",
+ "brace-expansion@<2": "1.1.18",
+ "brace-expansion@>=2": "2.1.4",
Review Comment:
[P2] Scope brace-expansion override by major
This blanket override now catches the `^5.0.2` dependency declared by the
current `@typescript-eslint/typescript-estree` subtree's `[email protected]`, but
the generated lock installs `[email protected]` instead. That unsupported
major downgrade can break or alter brace matching in the ESLint/typecheck
toolchain. Scope the override to `<5` and handle `>=5` with a compatible
release, or pin minimatch to a version that still declares the 2.x dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
