shoemoney commented on PR #20151: URL: https://github.com/apache/druid/pull/20151#issuecomment-5642783182
The eleven red jobs on `902448131e` were a single checkstyle violation, not the Netty 4 port. Fixed in `9947f370ba`. ``` NettyHttpClientTest.java:28:1: Wrong order for 'io.netty.handler.codec.http.HttpContent' import. [ImportOrder] ``` The three `io.netty` imports landed below the `org.apache.druid` block when I ported the test onto `51e31a68c2`. The ruleset is `groups="*,javax,java"` with `ordered=true`, so inside the first group `io.netty` sorts above `org.apache`. Every job builds `druid-processing` before anything else, so static-checks, strict-compilation, openrewrite, packaging-check, docker-tests and all seven unit-test shards failed at that same line and never reached `server/`, where the actual change lives. `mvn -rf :druid-processing` in the log is the tell. Only the import order moved. The other four files this PR touches are clean — the `javax` to `java` adjacency in `DirectDruidClient` and `JsonParserIterator` looks out of order but is suppressed deliberately by `codestyle/checkstyle-suppressions.xml` and matches the rest of the tree. Workflows on the new commit are sitting at `action_required`, so they need an approval before CI can confirm it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
