gianm commented on issue #7293: AggregatorFactory: Clarify methods that return other AggregatorFactories. URL: https://github.com/apache/incubator-druid/pull/7293#issuecomment-475054324 I have somewhat of a preference to avoiding doing incompatible changes for cosmetic, rather than functional reasons. I'd rather wait til we could _delete completely_ `getRequiredColumns()` -- it's only used for groupBy v1, which has been deprecated for a while, and could probably be removed once growable aggregators are implemented. (The only thing it really could do better than groupBy v2 is that it supports growable aggregators, since it uses on-heap rather than off-heap aggs.)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
