FrankChen021 commented on PR #20407: URL: https://github.com/apache/druid/pull/20407#issuecomment-5788590684
This automated compatibility review found a merge-blocking incompatibility in the proposed zstd-jni upgrade. Compatibility analysis The complete published release path is 1.5.7-11, 1.5.7-12, 1.5.7-13, 1.5.7-14, 1.5.7-15, 1.5.7-16, 1.5.7-17, and 1.5.7-18. Upstream documents 1.5.7-12 as the last release supporting legacy v0.4-v0.7 Zstandard frames; 1.5.7-13 removed that support and 1.5.7-18 retains the removal. Druid's processing/src/main/java/org/apache/druid/utils/CompressionUtils.java .zst ingestion path constructs ZstdCompressorInputStream, which reaches zstd-jni stream decoding. Existing Druid users supplying legacy .zst files can therefore receive an unknown-frame-descriptor failure after this dependency-only bump. This is an externally observable runtime and serialized-input compatibility regression. Druid's internal CompressionStrategy.ZSTD identifier and modern Druid-generated segment frames remain unchanged. Repair and validation The only bounded repair was updating licenses.yaml from zstd-jni 1.5.7-11 to 1.5.7-18; YAML parsing, BSD-2-Clause/POM consistency, git diff --check, and focused Maven dependency-tree resolution passed. No Druid production or test source changed. The prior C* failure was an unrelated compaction segment-count mismatch, but CI status does not affect the independent incompatibility decision. Closure decision The proposed dependency update is incompatible with Druid's supported legacy .zst ingestion behavior and cannot be approved without a compatibility-preserving code/design change beyond this bounded dependency bump. This PR is being closed as incompatible; no merge was performed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
