kgyrtkirk commented on code in PR #20273:
URL: https://github.com/apache/druid/pull/20273#discussion_r4090894668
##########
processing/src/main/java/org/apache/druid/java/util/http/client/pool/ResourcePool.java:
##########
@@ -355,6 +612,235 @@ public void close()
}
}
+ private static class AdaptiveResourceHolderPerKey<K, V> extends
PooledResources<V>
+ {
+ private static final int CREATE_ATTEMPTS = 3;
Review Comment:
in the end the whole attempts stuff was removed; the old logic was:
* with `eager=false`
* when there was none avail in the pool: a connection was created
* then later it was checked with `isGood` - if it failed it was created
again
* with `eager=true`
* the pool was filled up - so it could not happened that it was not in
the pool - unless it was at limit
* it was recreated when it was bad...
since `eager=true` was set by default ; the whole attempt stuff should be
off the table - everything was working fine with that...and should work.
The only thing I kept from this detour is a log message which might help to
know if we are encountering any issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
