FrankChen021 commented on code in PR #20314:
URL: https://github.com/apache/druid/pull/20314#discussion_r4093596637
##########
sql/src/main/java/org/apache/druid/sql/calcite/planner/PlannerFactory.java:
##########
@@ -326,6 +327,10 @@ public SqlConformance conformance()
if (aClass.equals(PlannerContext.class)) {
return (C) plannerContext;
}
+ if (aClass.equals(CancelFlag.class)) {
Review Comment:
## Follow-up assessment
## 🟡 Changes recommended
The intentional revert does not resolve the existing P2. In pinned Calcite
1.42, `Programs.of` and both stages returned by `Programs.subQuery` create
`HepPlanner(..., null, ...)`, so `AbstractRelOptPlanner` gives them private
cancellation flags. The `PlannerFactory` context added here is consumed by the
top-level Volcano planner, but a timeout during expression reduction, subquery
rewriting, or pre-Volcano/cleanup Hep work still cannot trip the query flag or
stop the rule loop. Testing a large `IN` where Volcano dominates does not
establish the broader guardrail promised by `maxPlanningTimeMs`.
Please either restore a cancel-aware Hep construction path, including both
subquery stages, with a focused regression test, or narrow the documented
guarantee to explicitly exclude those stages.
Reviewed 9 of 9 changed files. Finding: 1 (P2).
Validation: Static review only; `git diff --check
9f5363cc5f373120493a3552b503a973ca9e5b3b..f08893c0637518e4ce48b30329e6193f4dc36f6d`
completed without output. No builds, tests, dependency installs, or formatters
were run.
<!-- mergelens:review -->
---
This is an automated review by Codex GPT-5.6-Luna(max)
After addressing the findings or replying to the comments, you can request
another review from me to trigger a new automated review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
