FrankChen021 commented on code in PR #20450:
URL: https://github.com/apache/druid/pull/20450#discussion_r4134320531
##########
processing/src/main/java/org/apache/druid/segment/incremental/OnheapIncrementalIndex.java:
##########
@@ -706,6 +713,19 @@ public ColumnValueSelector<?>
makeColumnValueSelector(String columnName)
return existing != null ? existing : columnValueSelector;
}
+ @Override
+ public ColumnValueSelector<ExprEval> getOrCreateExprEvalSelector(final
Expr expression)
+ {
+ ColumnValueSelector<ExprEval> selector =
expressionSelectorMap.get(expression);
+ if (selector == null) {
+ // Do not use computeIfAbsent: building the expression selector can
re-enter makeColumnValueSelector on this
+ // factory through expression bindings.
+ selector = ExpressionSelectors.makeExprEvalSelectorUncached(this,
expression);
+ expressionSelectorMap.put(expression, selector);
Review Comment:
Looks like #19386 brings in the non-determinisc function `now()` that causes
this problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
