clintropolis opened a new pull request, #20460: URL: https://github.com/apache/druid/pull/20460
### Description `FrameProcessorExecutor.runFully` registers the processor's return future and the processor itself in two separate synchronized blocks. A `cancel(cancellationId)` that occurs between them ends up canceling `cancelableProcessors` without ever seeing the processor, but `registerCancelableProcessor` registered it anyway, leaving an entry that no cancel will ever remove. To fix, this PR modifies `registerCancelableProcessor` to return false if the `cancellationId` is not present (similar to what `registerCancelableFuture` does already), and cancels the processor like it would have done if it had been registered properly and been 'seen' by the cancel. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
