FrankChen021 opened a new pull request, #20470:
URL: https://github.com/apache/druid/pull/20470

   ### Description
   
   The latest `master` commit, 46e8f93eb8 (#19598), adds a listener in 
`testTaskLocationUsesAdvertisedPlaintextPort` that implements `locationChanged` 
and `statusChanged` with `String` task IDs. #20417 had already changed 
`TaskRunnerListener` to receive `Task` objects, so the new anonymous listener 
fails test compilation and blocks the CI jobs that compile indexing-service 
tests.
   
   Update both callbacks to accept `Task`, matching the current interface. The 
existing advertised-port assertion is preserved.
   
   Failure examples: [static 
checks](https://github.com/apache/druid/actions/runs/36868919227/job/110391349127),
 [unit 
tests](https://github.com/apache/druid/actions/runs/36868919865/job/110391350706),
 and [web 
checks](https://github.com/apache/druid/actions/runs/36868919227/job/110391349546).
   
   ### Validation
   
   On JDK 25:
   
   - `mvn test -pl indexing-service -am -Dtest=ThreadingTaskRunnerTest 
-Dsurefire.failIfNoSpecifiedTests=false -Pskip-static-checks 
-Dweb.console.skip=true -T1C` — passed; all 3 tests passed and reactor test 
compilation succeeded.
   - `mvn checkstyle:check -pl indexing-service -Dweb.console.skip=true` — 
passed with 0 violations.
   - `git diff --check` — passed.
   
   ##### Key changed classes in this PR
   
   * `ThreadingTaskRunnerTest`
   
   This PR has:
   
   - [x] been self-reviewed.
   - [x] modified an existing test to match the current listener API and 
verified its assertions pass.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to