FrankChen021 commented on code in PR #20471:
URL: https://github.com/apache/druid/pull/20471#discussion_r4173094736
##########
extensions-core/kafka-indexing-service/pom.xml:
##########
@@ -67,6 +67,18 @@
</exclusion>
</exclusions>
</dependency>
+ <!-- Provides the AWS_MSK_IAM SASL mechanism; its AWS SDK comes from
druid-aws-common, so no transitives ship. -->
+ <dependency>
+ <groupId>software.amazon.msk</groupId>
+ <artifactId>aws-msk-iam-auth</artifactId>
+ <scope>runtime</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
Review Comment:
## Follow-up assessment
Thanks for the clarification. I rechecked the current head across all 8
changed files, including both extension POMs and Druid's existing
`AWSCredentialsUtils.defaultAWSCredentialsProviderChain`. The missing SSO
modules are already absent from the shared `druid-aws-common` classpath, and
this PR does not change that path, so the SSO limitation is not a PR-caused
regression. I am withdrawing the P2 finding; no further action is needed on
this thread.
Reviewed 8 of 8 changed files; this follow-up has 0 remaining findings.
Static `git diff --check e855cd9c3316710361c7f2cf0b1b8331141c20ad
ebf673d4c13d903eaccbe4995a2308733b7ddc32` passed; no tests or builds were run.
<!-- mergelens:review -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
