amaechler opened a new pull request, #20495:
URL: https://github.com/apache/druid/pull/20495

   ### Description
   
   #19175 moved the protobuf event serializers into `embedded-tests`, and they 
still built their `Wikipedia` schema with `com.github.os72:protobuf-dynamic`. 
#18401 already replaced that library with built-in protobuf methods in 
`druid-protobuf-extensions`; this PR does the same for `embedded-tests`.
   
   #### Removed the dependency
   
   Dropped `com.github.os72:protobuf-dynamic` from `embedded-tests/pom.xml` and 
`quidem-ut/pom.xml`. Nothing in `quidem-ut` references it; it appears to date 
from #16624, when `druid-protobuf-extensions` still needed it at runtime.
   
   <hr>
   
   This PR has:
   
   - [x] been self-reviewed.
   - [x] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to