FrankChen021 commented on code in PR #19609:
URL: https://github.com/apache/druid/pull/19609#discussion_r4205903717
##########
processing/src/main/java/org/apache/druid/data/input/impl/CloudObjectLocation.java:
##########
@@ -46,6 +47,8 @@
*/
public class CloudObjectLocation
{
+ private static final Pattern S3_ARN =
Pattern.compile("^arn:(aws|aws-cn|aws-us-gov):s3:[a-z0-9-]*:\\d{12}:accesspoint:[A-Za-z0-9.-]+$");
Review Comment:
the only concern is that this pattern exists in this CloudObjectLocation
which should not be aware of any specific provider like S3. And also you if
look at the regular expression here and the one in the S3Utils, they're
different.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
