kgyrtkirk commented on code in PR #20537: URL: https://github.com/apache/druid/pull/20537#discussion_r4227572753
########## multi-stage-query/src/main/java/org/apache/druid/msq/dart/controller/DartControllerContextFactoryImpl.java: ########## @@ -56,7 +55,7 @@ public class DartControllerContextFactoryImpl implements DartControllerContextFa protected final MemoryIntrospector memoryIntrospector; protected final List<InputSpecSlicerProvider> inputSpecSlicerProviders; protected final ServiceEmitter emitter; - protected final DruidNodeDiscovery dartWorkerDiscovery; Review Comment: note: I think it might worth a try to add an annotated `DruidNodeDiscovery` similar to `@Dart` ; and declare a method do produce that in a guice module... and depend on that that way guice will see that factorization happening and could plan it into the construction timeline of this object (or error out with some reasoning ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
