kfaraz commented on code in PR #20505:
URL: https://github.com/apache/druid/pull/20505#discussion_r4260830568
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java:
##########
@@ -2945,27 +3021,62 @@ public boolean
isAnotherTaskGroupPublishingToPartitions(String taskId, Set<Objec
});
if (partitionIdToPublishingGroups.isEmpty()) {
- return false;
+ return Map.of();
}
// Check if any of the partitions of this taskId are being published by
other taskGroups
+ final Map<TaskGroup, Set<PartitionIdType>> blockingTaskGroups = new
HashMap<>();
for (Object partition : partitions) {
@SuppressWarnings("unchecked")
final PartitionIdType partitionId = (PartitionIdType) partition;
if (partitionIdToPublishingGroups.containsKey(partitionId)) {
- log.info(
- "Task[%s] needs to wait before publishing as other taskGroups[%s]
are currently publishing to partition[%s].",
- taskId,
- partitionIdToPublishingGroups.get(partitionId),
- partitionId
- );
- return true;
+ for (TaskGroup taskGroup :
partitionIdToPublishingGroups.get(partitionId)) {
Review Comment:
Updated the method in SeekableStreamSupervisor to wait on older task groups
only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
